Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update backward compatibility tests for LR progress tracker changes made in #2877. #2904

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Update backward compatibility tests for LR progress tracker changes made in #2877. #2904

merged 1 commit into from
Jan 7, 2023

Conversation

justinxzhao
Copy link
Contributor

@justinxzhao justinxzhao commented Jan 6, 2023 •
edited
Loading

  • best_reduce_learning_rate_eval_metric and last_reduce_learning_rate_eval_metric_improvement were removed in Adopt PyTorch official LRScheduler API #2877, but we left out updating upgrade_model_progress to account for these removals.

@justinxzhao justinxzhao requested a review from tgaddair January 6, 2023 17:53
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Unit Test Results

         6 files  ±  0           6 suites  ±0   4h 17m 52s ⏱️ - 21m 29s
  3 576 tests ±  0    3 504 ✔️ ±  0    72 💤 ±0  0 ❌ ±0 
10 686 runs   - 42  10 454 ✔️  - 41  232 💤  - 1  0 ❌ ±0 

Results for commit 57e4862. ± Comparison against base commit 46afd26.

@justinxzhao justinxzhao merged commit 25135fe into master Jan 7, 2023
@justinxzhao justinxzhao deleted the fix_backward_compatibility branch January 7, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnavgarg1 arnavgarg1 arnavgarg1 approved these changes

@hungcs hungcs hungcs approved these changes

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinxzhao @hungcs @arnavgarg1