Evaluate training set in the training loop (GBM) #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
reviewed
Jan 10, 2023
justinxzhao
approved these changes
Jan 11, 2023
jeffkinnison
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
LGTM! Great work smoothing out some rough edges in addition to recording training set metrics.
Completely as a question for another day, would it be possible to remove train_step from LightGBMRayTrainer to reduce code duplication? Maybe by recording the various LGBM model classes within their trainer classes?
jeffkinnison
approved these changes
Jan 12, 2023
jeffkinnison
approved these changes
Jan 13, 2023
jppgks
force-pushed
the
no-eval-train-gbm
branch
2 times, most recently
from
2151f24 to
d856dc9
Compare
for more information, see https://pre-commit.ci
Disable feature filtering to avoid having no features due to small test dataset, see https://stackoverflow.com/a/66405983/5222402
for more information, see https://pre-commit.ci
jppgks
force-pushed
the
no-eval-train-gbm
branch
from
4ecc3f7 to
70de7d5
Compare
jeffkinnison
pushed a commit
that referenced
this pull request
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement to #2856