Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store mlflow tracking URI to ensure consistency across processes #2927

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

tgaddair
Copy link
Collaborator

In the previous implementation, we pull the tracking URI from the environment every time we change context, which can result in inconsistent behavior if, for example, the current working directory changes and no external MLFlow service is being used.

Copy link
Contributor

@geoffreyangus geoffreyangus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Unit Test Results

         6 files  ±  0           6 suites  ±0   5h 12m 58s ⏱️ + 20m 30s
  3 883 tests +  1    3 809 ✔️ +  1    74 💤 ±  0  0 ±0 
11 649 runs  +89  11 427 ✔️ +74  222 💤 +15  0 ±0 

Results for commit c7fe7c6. ± Comparison against base commit dd2123d.

@tgaddair tgaddair merged commit f433b89 into master Jan 13, 2023
@tgaddair tgaddair deleted the fix-ray-mlflow branch January 13, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants