Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable bagging when using GOSS GBM boosting type #2956

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Disable bagging when using GOSS GBM boosting type #2956

merged 2 commits into from
Jan 18, 2023

Conversation

jeffkinnison
Copy link
Contributor

Bagging is not compatible with LightGBM's GOSS boosting type, and a config with boosting_type: goss and bagging_freq > 0 will throw the following liblightgbm error:

lightgbm.basic.LightGBMError: Cannot use bagging in GOSS

This update had the trainer automatically set bagging_freq: 0 when using GOSS.

@jeffkinnison jeffkinnison self-assigned this Jan 18, 2023
@github-actions
Copy link

github-actions bot commented Jan 18, 2023 •
edited
Loading

Unit Test Results

         6 files  ±    0           6 suites  ±0   4h 34m 32s ⏱️ - 37m 5s
  3 896 tests +    1    3 822 ✔️ +    2    74 💤 ±  0  0 ❌  - 1 
11 685 runs  +139  11 463 ✔️ +114  222 💤 +26  0 ❌  - 1 

Results for commit 8155e49. ± Comparison against base commit 36fcb38.

♻️ This comment has been updated with latest results.

@jeffkinnison jeffkinnison merged commit 583c35b into master Jan 18, 2023
@jeffkinnison jeffkinnison deleted the goss-disable-bagging branch January 18, 2023 22:59
@justinxzhao justinxzhao mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnavgarg1 arnavgarg1 arnavgarg1 approved these changes

@justinxzhao justinxzhao justinxzhao approved these changes

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair is a code owner

@jppgks jppgks Awaiting requested review from jppgks

Assignees

@jeffkinnison jeffkinnison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffkinnison @justinxzhao @arnavgarg1