Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected Impact Calibration #2960

Merged
merged 28 commits into from
Jan 19, 2023
Merged

Expected Impact Calibration #2960

merged 28 commits into from
Jan 19, 2023

Conversation

connor-mccorm
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 19, 2023 •
edited
Loading

Unit Test Results

         6 files  ±0           6 suites  ±0   5h 26m 29s ⏱️ + 35m 14s
  3 898 tests +2    3 826 ✔️ +  4    72 💤  - 2  0 ❌ ±0 
11 691 runs  +6  11 475 ✔️ +12  216 💤  - 6  0 ❌ ±0 

Results for commit 525c4b7. ± Comparison against base commit 3b84d9b.

♻️ This comment has been updated with latest results.

@connor-mccorm connor-mccorm marked this pull request as ready for review January 19, 2023 06:28
@connor-mccorm connor-mccorm changed the title Filtering fixes Filtering Fixes Jan 19, 2023
@connor-mccorm connor-mccorm changed the title Filtering Fixes Expected Impact Calibration Jan 19, 2023
ksbrar
ksbrar approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@ksbrar ksbrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summarizing the parameters I noticed newly set to internal_only in some instances:

  • input_size
  • vocab_size
  • max_sequence_length
  • saved_weights_in_checkpoint
  • vocab
  • should_embed
  • height

@connor-mccorm connor-mccorm merged commit c85cc57 into master Jan 19, 2023
@connor-mccorm connor-mccorm deleted the filtering-fixes branch January 19, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbrar ksbrar ksbrar approved these changes

@justinxzhao justinxzhao justinxzhao approved these changes

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair is a code owner

@w4nderlust w4nderlust Awaiting requested review from w4nderlust w4nderlust is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connor-mccorm @justinxzhao @ksbrar