Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fill_with_mode when using Dask #3054

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Fix fill_with_mode when using Dask #3054

merged 2 commits into from
Feb 7, 2023

Conversation

arnavgarg1
Copy link
Contributor

Dask returns a Dask index structure because of lazy evaluation, so we need to force computation of the value_counts() method so we can grab the mode of the column to use as the fill_value.

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Unit Test Results

         6 files  ±  0           6 suites  ±0   5h 4m 59s ⏱️ - 18m 51s
  3 890 tests +  2    3 853 ✔️ +  2    37 💤 ±  0  0 ±0 
11 667 runs  +68  11 556 ✔️ +55  111 💤 +13  0 ±0 

Results for commit e37e685. ± Comparison against base commit aa88052.

Copy link
Contributor

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@arnavgarg1 arnavgarg1 merged commit a5bb742 into master Feb 7, 2023
@arnavgarg1 arnavgarg1 deleted the fill_with_mode_dask branch February 7, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants