Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use TypeSelection to power optimizer field #3071

Merged
merged 9 commits into from
Feb 21, 2023

Conversation

ksbrar
Copy link
Collaborator

@ksbrar ksbrar commented Feb 9, 2023

Quick change - trying out the new TypeSelection class

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Unit Test Results

         5 files   -     1           5 suites   - 1   4h 30m 19s ⏱️ - 1h 24m 27s
  3 967 tests ±    0    3 930 ✔️ ±    0  37 💤 ±  0  0 ±0 
11 651 runs   - 202  11 565 ✔️  - 178  86 💤  - 24  0 ±0 

Results for commit 7c49b01. ± Comparison against base commit 6fd8cb0.

♻️ This comment has been updated with latest results.

@ksbrar ksbrar changed the title int: Refactor optimizer field to use TypeSelection refactor: Use TypeSelection to power optimizer field Feb 21, 2023
@ksbrar ksbrar requested review from arnavgarg1 and tgaddair and removed request for tgaddair February 21, 2023 04:08
@ksbrar ksbrar merged commit 9bb0beb into ludwig-ai:master Feb 21, 2023
@ksbrar ksbrar deleted the optimizer-field-refactor branch February 21, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants