Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not default to adding None as accepted tuple for FloatRangeTupleDataclassField #3146

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Not default to adding None as accepted tuple for FloatRangeTupleDataclassField #3146

merged 1 commit into from
Feb 27, 2023

Conversation

abidwael
Copy link
Contributor

Factor allow_none in whether to allow None value or not.

@github-actions
Copy link

Unit Test Results

         5 files  ±0           5 suites  ±0   4h 32m 5s ⏱️ - 1m 31s
  3 976 tests ±0    3 936 ✔️ ±0    40 💤 ±0  0 ❌ ±0 
11 738 runs  ±0  11 636 ✔️ ±0  102 💤 ±0  0 ❌ ±0 

Results for commit 2836319. ± Comparison against base commit 9b323d0.

@abidwael abidwael requested a review from ksbrar February 27, 2023 05:25
ksbrar
ksbrar approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@ksbrar ksbrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@abidwael abidwael merged commit 1199580 into master Feb 27, 2023
@abidwael abidwael deleted the remove-null-from-floatrangetuple branch February 27, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbrar ksbrar ksbrar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abidwael @ksbrar