fix: Move target tensor to model output device in check_module_parameters_updated

[jeffkinnison]

Running any test that calls tests.integration_tests.parameter_update_utils.check_module_parameters_updated in an environment with a GPU leads to a device mismatch error, with the model on GPU and the target tensor on CPU. This fixes the device mismatch by putting the target tensor on the model device in this function.

[github-actions]

Unit Test Results

  6 files  ±       0    6 suites  ±0   1h 11m 47s ⏱️ - 17m 37s
34 tests  - 2 772  29 ✔️  - 2 764    5 💤  - 7  0 ❌  - 1 
88 runs   - 2 761  72 ✔️  - 2 755  16 💤  - 5  0 ❌  - 1 

Results for commit 91b90d5. ± Comparison against base commit 4a72e67.

♻️ This comment has been updated with latest results.

[jeffkinnison]

Updated because some inputs have a device attribute and some don't. Instead, we set the device to match the model output passed into the loss function.

[jeffkinnison]

Just so it's noted, we still get 48 tabtransformer failures with this fix, though it seems to be because tabtransformer parameters aren't updating.

FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-None-concat-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-None-concat-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-None-concat-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-None-concat-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-None-sum-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-None-sum-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-None-sum-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-None-sum-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-fc_layers1-concat-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-fc_layers1-concat-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-fc_layers1-concat-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-fc_layers1-concat-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-fc_layers1-sum-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-fc_layers1-sum-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-fc_layers1-sum-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[None-fc_layers1-sum-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['laye...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-None-concat-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-None-concat-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-None-concat-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-None-concat-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-None-sum-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-None-sum-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-None-sum-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-None-sum-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-fc_layers1-concat-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-fc_layers1-concat-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-fc_layers1-concat-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-fc_layers1-concat-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-fc_layers1-sum-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-fc_layers1-sum-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-fc_layers1-sum-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[64-fc_layers1-sum-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-None-concat-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-None-concat-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-None-concat-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-None-concat-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-None-sum-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-None-sum-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-None-sum-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-None-sum-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-fc_layers1-concat-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-fc_layers1-concat-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-fc_layers1-concat-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-fc_layers1-concat-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-fc_layers1-sum-1-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-fc_layers1-sum-1-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-fc_layers1-sum-2-feature_list0] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...
FAILED tests/ludwig/combiners/test_combiners.py::test_tabtransformer_combiner_number_or_binary_without_category[add-fc_layers1-sum-2-feature_list2] - AssertionError: Failed to update parameters. Parameters not updated: ['embe...