Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WandB: Add metric logging support on eval end and epoch end #3586

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

arnavgarg1
Copy link
Contributor

@arnavgarg1 arnavgarg1 commented Sep 5, 2023

Our current callback implementation only logs the dataset, but not any metrics.

Confirmed that this branch works if you also downgrade wandb to 0.12.10. We should spend time fixing our integration/making it compatible with the latest version of wandb, but for now, this fix should suffice.

FYI, it's not clear what the issue is with the latest version (no code errors, just doesn't push metrics up to wandb). Here's the slack thread for context: https://ludwig-ai.slack.com/archives/C01PN6M2RSM/p1693941105546379

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Unit Test Results

       6 files  ±       0         6 suites  ±0   1h 54m 16s ⏱️ + 25m 10s
2 822 tests  -        4  2 785 ✔️  -        5  12 💤 ±  0  25 +1 
8 431 runs  +5 562  8 374 ✔️ +5 550  31 💤 +10  26 +2 

For more details on these failures, see this check.

Results for commit cc7929e. ± Comparison against base commit e1d023e.

@arnavgarg1 arnavgarg1 merged commit 07ea472 into master Sep 5, 2023
@arnavgarg1 arnavgarg1 deleted the wandb_integration branch September 5, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants