Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed range validation for text generation penalty parameters #3623

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Fixed range validation for text generation penalty parameters #3623

merged 1 commit into from
Sep 16, 2023

Conversation

tgaddair
Copy link
Collaborator

These param ranges were overly restrictive. See https://huggingface.co/docs/transformers/internal/generation_utils for more details.

@tgaddair tgaddair requested a review from arnavgarg1 September 16, 2023 20:59
arnavgarg1
arnavgarg1 approved these changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, good catch!

jeffkinnison
jeffkinnison approved these changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@jeffkinnison jeffkinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for a more general float field type

@github-actions
Copy link

Unit Test Results

  4 files   -   2    4 suites   - 2   36m 51s ⏱️ - 5m 35s
31 tests ±  0  26 ✔️ ±  0    5 💤 ±0  0 ❌ ±0 
62 runs   - 20  52 ✔️  - 14  10 💤  - 6  0 ❌ ±0 

Results for commit 7b218b7. ± Comparison against base commit 4806254.

@tgaddair tgaddair merged commit 42723e3 into master Sep 16, 2023
@tgaddair tgaddair deleted the fix-rep-penalty branch September 16, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnavgarg1 arnavgarg1 arnavgarg1 approved these changes

@jeffkinnison jeffkinnison jeffkinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgaddair @jeffkinnison @arnavgarg1