-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Use a torch-nightly-compatible version of torchaudio #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
changed the title
[ci] Unpin torchaudio nightly
[CI] Unpin torchaudio nightly
Sep 20, 2023
Unit Test Results 6 files + 2 6 suites +2 40m 31s ⏱️ + 6m 53s Results for commit 4d565b6. ± Comparison against base commit c24deca. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
…ken due to soundfile changes. Skip build synthetic data test.
…or torch nightly.
justinxzhao
changed the title
[CI] Unpin torchaudio nightly
[CI] Use a torch-nightly-compatible version of torchaudio
Sep 21, 2023
arnavgarg1
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
torchaudio==2.1
, which is incompatible with torch nightly, v2.2.torchaudio.save/read
when dealing with audio files.test_audio_feature.py::test_add_feature_data
,test_training_determinism_local_backend
andtest_build_synthetic_dataset
for torch nightly. The first item requires a deeper change to our custom implementation ofstft
(maybe this can be replaced this with the torch-native implementation).