Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use a torch-nightly-compatible version of torchaudio #3644

Merged
merged 16 commits into from
Sep 21, 2023
Merged

Conversation

justinxzhao
Copy link
Contributor

@justinxzhao justinxzhao commented Sep 20, 2023

Notes:

  • Torch nightly is now running 2.2+.
  • We unpin nightly torchaudio==2.1, which is incompatible with torch nightly, v2.2.
  • Based on torchaudio's dispatcher migration, audio IO should move to using soundfile instead of torchaudio.save/read when dealing with audio files.
  • We skip test_audio_feature.py::test_add_feature_data, test_training_determinism_local_backend and test_build_synthetic_dataset for torch nightly. The first item requires a deeper change to our custom implementation of stft (maybe this can be replaced this with the torch-native implementation).
  • Filed Unskip torchaudio-related tests that are incompatible with torch 2.2.0 #3645.

@justinxzhao justinxzhao changed the title Unpin torchaudio nightly [ci] Unpin torchaudio nightly Sep 20, 2023
@justinxzhao justinxzhao changed the title [ci] Unpin torchaudio nightly [CI] Unpin torchaudio nightly Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Unit Test Results

  6 files  +  2    6 suites  +2   40m 31s ⏱️ + 6m 53s
30 tests  -   1  25 ✔️  -   1    5 💤 ±0  0 ±0 
79 runs  +17  63 ✔️ +11  16 💤 +6  0 ±0 

Results for commit 4d565b6. ± Comparison against base commit c24deca.

This pull request removes 1 test.
tests.regression_tests.model.test_old_models ‑ test_predict_deprecated_model[respiratory]

♻️ This comment has been updated with latest results.

@justinxzhao justinxzhao marked this pull request as ready for review September 21, 2023 01:38
…ken due to soundfile changes. Skip build synthetic data test.
@justinxzhao justinxzhao marked this pull request as draft September 21, 2023 05:43
@justinxzhao justinxzhao changed the title [CI] Unpin torchaudio nightly [CI] Use a torch-nightly-compatible version of torchaudio Sep 21, 2023
@justinxzhao justinxzhao marked this pull request as ready for review September 21, 2023 14:49
@justinxzhao justinxzhao merged commit 4f12793 into master Sep 21, 2023
@justinxzhao justinxzhao deleted the fix_ci branch September 21, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants