Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment epochs based on last_batch() instead of at the end of the train loop. #3668

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

justinxzhao
Copy link
Contributor

self._train_loop() trains over a full epoch of data or up to the last training step, whichever is sooner, so we should only increment epochs when last_batch() is True as a check within self._train_loop().

This fixes a potential issue with the last epoch being 1 too high when the training runway concludes partway through an epoch.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Unit Test Results

       5 files   -   1         5 suites   - 1   51m 6s ⏱️ -5s
2 807 tests ±  0  2 793 ✔️ ±0  12 💤 ±0  2 ±0 
2 835 runs   - 12  2 815 ✔️  - 9  18 💤  - 3  2 ±0 

For more details on these failures, see this check.

Results for commit e7178ab. ± Comparison against base commit 4af5331.

♻️ This comment has been updated with latest results.

@justinxzhao justinxzhao marked this pull request as ready for review September 26, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants