Increment epochs based on last_batch() instead of at the end of the train loop. #3668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self._train_loop()
trains over a full epoch of data or up to the last training step, whichever is sooner, so we should only increment epochs whenlast_batch()
isTrue
as a check withinself._train_loop()
.This fixes a potential issue with the last epoch being 1 too high when the training runway concludes partway through an epoch.