Place metric functions for BLEU and Rogue on correct devices when using multiple GPUs #3671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the metric function wasn't being moved/placed on the right device, leading to a weird behavior for these metrics using the
response
prediction key because the inputs that are passed in are not tensors, they're lists of strings. However, it seems like these metric functions need to moved to CUDA (instead of staying on the CPU) so that when the metric_fn.compute() call is called to gather evaluation metric summaries, it does not run into this error:Tested successfully with: