Add support for exporting models to Carton #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivekPanyam
force-pushed
the
add_carton
branch
from
235299d to
b01cf48
Compare
| # set_feature(vocab_size=3), | ||
| # vector_feature() | ||
| ] | ||
| backend = LocalTestBackend() |
There was a problem hiding this comment.
We have several definitions of the LocalTestbackend() including the fixture in tests/integration_tests/test_llm.py -- note to self: Unify them, if possible (e.g., in a conftest.py type of a file).
|
Hi @VivekPanyam! Thanks for creating this PR - let us know when it's ready for review. |
VivekPanyam
requested review from
w4nderlust,
tgaddair,
justinxzhao,
arnavgarg1,
geoffreyangus,
jeffkinnison and
Infernaught
as code owners
Hi! I was going to add |
alexsherstinsky
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed with @tgaddair, this PR adds support for exporting Ludwig models to Carton.
VivekPanyam/carton#162
Background
Carton is a library with the goal of allowing users to run any ML model from any programming language.
It currently supports C, C++, Rust, and Python with support for other languages in progress (NodeJS, OCaml, C#). See the link above or the repo at https://github.com/VivekPanyam/carton for more details.
Implementation
This PR is heavily based on the
export_neuropodfunctionality already implemented in Ludwig. It mirrors the implementation and integration tests.Test plan
Added an integration test and verified that it passes locally.
TODO
export_cartonto the documentation