Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Bump minimum tokenizers to 0.15 #3856

Merged
merged 2 commits into from
Jan 4, 2024
Merged

[Maintenance] Bump minimum tokenizers to 0.15 #3856

merged 2 commits into from
Jan 4, 2024

Conversation

arnavgarg1
Copy link
Contributor

@arnavgarg1 arnavgarg1 commented Jan 4, 2024

Required for transformers 4.36

The conflict is caused by:
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
    ludwig 0.9.dev0 depends on tokenizers>=0.13.3
    ludwig[test] 0.9.dev0 depends on tokenizers>=0.13.3
    transformers 4.36.2 depends on tokenizers<0.19 and >=0.14
    ludwig 0.9.dev0 depends on tokenizers>=0.13.3
    ludwig[test] 0.9.dev0 depends on tokenizers>=0.13.3
    transformers 4.36.1 depends on tokenizers<0.19 and >=0.14
    ludwig 0.9.dev0 depends on tokenizers>=0.13.3
    ludwig[test] 0.9.dev0 depends on tokenizers>=0.13.3
    transformers 4.36.0 depends on tokenizers<0.19 and >=0.14

Tokenizers 0.14 is linked to huggingface hub < 0.17, but transformers 4.36 requires huggingface hub >= 0.19

@arnavgarg1 arnavgarg1 changed the title [Maintenance] Bump minimum tokenizers to 0.14 [Maintenance] Bump minimum tokenizers to 0.15 Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

Unit Test Results

  6 files  ±0    6 suites  ±0   13m 54s ⏱️ +2s
12 tests ±0    9 ✔️ ±0    3 💤 ±0  0 ±0 
60 runs  ±0  42 ✔️ ±0  18 💤 ±0  0 ±0 

Results for commit 85a80f3. ± Comparison against base commit d45566b.

Copy link
Collaborator

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arnavgarg1 arnavgarg1 merged commit 9621757 into master Jan 4, 2024
18 checks passed
@arnavgarg1 arnavgarg1 deleted the tokenizer branch January 4, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants