Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct typo in FeatureCollection #3863

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: correct typo in FeatureCollection #3863

merged 1 commit into from
Jan 8, 2024

Conversation

dennisrall
Copy link
Contributor

@dennisrall dennisrall commented Jan 8, 2024 •
edited
Loading

I think there is a bug/typo in the FeatureCollection class

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Unit Test Results

  6 files  ±0    6 suites  ±0   13m 35s ⏱️ -33s
12 tests ±0    7 ✔️  -   2    5 💤 +  2  0 ❌ ±0 
60 runs  ±0  30 ✔️  - 12  30 💤 +12  0 ❌ ±0 

Results for commit 6c11ee6. ± Comparison against base commit 9621757.

This pull request skips 2 tests. 
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml]

arnavgarg1
arnavgarg1 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@arnavgarg1 arnavgarg1 merged commit cfecf36 into ludwig-ai:master Jan 8, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnavgarg1 arnavgarg1 arnavgarg1 approved these changes

@w4nderlust w4nderlust Awaiting requested review from w4nderlust w4nderlust is a code owner

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair is a code owner

@justinxzhao justinxzhao Awaiting requested review from justinxzhao justinxzhao is a code owner

@geoffreyangus geoffreyangus Awaiting requested review from geoffreyangus geoffreyangus is a code owner

@jeffkinnison jeffkinnison Awaiting requested review from jeffkinnison jeffkinnison is a code owner

@Infernaught Infernaught Awaiting requested review from Infernaught Infernaught is a code owner

@alexsherstinsky alexsherstinsky Awaiting requested review from alexsherstinsky alexsherstinsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisrall @arnavgarg1