-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Comment Out PyTorch Nightly Test #3955
Merged
alexsherstinsky
merged 29 commits into
master
from
bugfix/alexsherstinsky/integration_tests/use_index_url_instead_of_extra_index_url_for_torch_nightly_installation-2024_03_06-31
Mar 7, 2024
Merged
[MAINTENANCE] Comment Out PyTorch Nightly Test #3955
alexsherstinsky
merged 29 commits into
master
from
bugfix/alexsherstinsky/integration_tests/use_index_url_instead_of_extra_index_url_for_torch_nightly_installation-2024_03_06-31
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 6 files + 2 6 suites +2 14m 9s ⏱️ + 4m 29s For more details on these failures, see this check. Results for commit 973f9eb. ± Comparison against base commit 40184ae. ♻️ This comment has been updated with latest results. |
…y (and adding the find links option in order to get access to setuptools in the isolated environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
alexsherstinsky
changed the title
[BUGFIX] Use index URL instead of extra index URL in specifying PyTorch nightly.
[BUGFIX] Fix PyTorch Nightly Test
Mar 6, 2024
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
alexsherstinsky
changed the title
[BUGFIX] Fix PyTorch Nightly Test
[MAINTENANCE] Comment Out PyTorch Nightly Test
Mar 6, 2024
alexsherstinsky
requested review from
w4nderlust,
tgaddair,
justinxzhao,
arnavgarg1,
geoffreyangus,
jeffkinnison and
Infernaught
as code owners
March 7, 2024 03:19
…se_index_url_instead_of_extra_index_url_for_torch_nightly_installation-2024_03_06-31
justinxzhao
approved these changes
Mar 7, 2024
alexsherstinsky
deleted the
bugfix/alexsherstinsky/integration_tests/use_index_url_instead_of_extra_index_url_for_torch_nightly_installation-2024_03_06-31
branch
March 7, 2024 16:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
We get an error while installing PyTorch nightly:
Documentation states to use the following command:
But then unit tests fail, because
torchtext
is not found.Numerous attempts to reconcile these dependencies have not led to success; so we are disabling the PyTorch nightly test.
Code Pull Requests
Please provide the following:
Documentation Pull Requests
Note that the documentation HTML files are in
docs/
while the Markdown sources are inmkdocs/docs
.If you are proposing a modification to the documentation you should change only the Markdown files.
api.md
is automatically generated from the docstrings in the code, so if you want to change something in that file, first modifyludwig/api.py
docstring, then runmkdocs/code_docs_autogen.py
, which will createmkdocs/docs/api.md
.