Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Comment Out PyTorch Nightly Test #3955

Conversation

alexsherstinsky
Copy link
Collaborator

@alexsherstinsky alexsherstinsky commented Mar 6, 2024

Scope

We get an error while installing PyTorch nightly:

ERROR: HTTP error 403 while getting https://download.pytorch.org/whl/nightly/nvidia_cuda_nvrtc_cu12-12.1.105-py3-none-manylinux1_x86_64.whl (from https://download.pytorch.org/whl/nightly/cpu/nvidia-cuda-nvrtc-cu12/)
2024-02-12T19:11:26.3258455Z ERROR: Could not install requirement nvidia-cuda-nvrtc-cu12==12.1.105 from https://download.pytorch.org/whl/nightly/nvidia_cuda_nvrtc_cu12-12.1.105-py3-none-manylinux1_x86_64.whl (from torch) because of HTTP error 403 Client Error: Forbidden for url: https://download.pytorch.org/whl/nightly/nvidia_cuda_nvrtc_cu12-12.1.105-py3-none-manylinux1_x86_64.whl for URL https://download.pytorch.org/whl/nightly/nvidia_cuda_nvrtc_cu12-12.1.105-py3-none-manylinux1_x86_64.whl (from https://download.pytorch.org/whl/nightly/cpu/nvidia-cuda-nvrtc-cu12/)

Documentation states to use the following command:

pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cpu

But then unit tests fail, because torchtext is not found.

Numerous attempts to reconcile these dependencies have not led to success; so we are disabling the PyTorch nightly test.

Code Pull Requests

Please provide the following:

  • a clear explanation of what your code does
  • if applicable, a reference to an issue
  • a reproducible test for your PR (code, config and data sample)

Documentation Pull Requests

Note that the documentation HTML files are in docs/ while the Markdown sources are in mkdocs/docs.

If you are proposing a modification to the documentation you should change only the Markdown files.

api.md is automatically generated from the docstrings in the code, so if you want to change something in that file, first modify ludwig/api.py docstring, then run mkdocs/code_docs_autogen.py, which will create mkdocs/docs/api.md .

Copy link

github-actions bot commented Mar 6, 2024

Unit Test Results

  6 files  +  2    6 suites  +2   14m 9s ⏱️ + 4m 29s
12 tests ±  0    8 ✔️  -   1    3 💤 ±0  1 +1 
60 runs  +20  41 ✔️ +13  18 💤 +6  1 +1 

For more details on these failures, see this check.

Results for commit 973f9eb. ± Comparison against base commit 40184ae.

♻️ This comment has been updated with latest results.

…y (and adding the find links option in order to get access to setuptools in the isolated environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
@alexsherstinsky alexsherstinsky changed the title [BUGFIX] Use index URL instead of extra index URL in specifying PyTorch nightly. [BUGFIX] Fix PyTorch Nightly Test Mar 6, 2024
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
…y (and adding the no build isolation in order to get access to setuptools in the environment).
@alexsherstinsky alexsherstinsky changed the title [BUGFIX] Fix PyTorch Nightly Test [MAINTENANCE] Comment Out PyTorch Nightly Test Mar 6, 2024
…se_index_url_instead_of_extra_index_url_for_torch_nightly_installation-2024_03_06-31
@alexsherstinsky alexsherstinsky merged commit e0f112c into master Mar 7, 2024
15 of 18 checks passed
@alexsherstinsky alexsherstinsky deleted the bugfix/alexsherstinsky/integration_tests/use_index_url_instead_of_extra_index_url_for_torch_nightly_installation-2024_03_06-31 branch March 7, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants