Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make react-native-windows peer dependency optional #585

Conversation

mjgallag
Copy link
Contributor

@mjgallag mjgallag commented Jun 4, 2021

@mjgallag mjgallag force-pushed the make-react-native-windows-peer-dependency-optional branch from 345e860 to cfd33ce Compare June 30, 2021 20:34
Copy link
Collaborator

@luancurti luancurti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You! Awesome! 🎉

@luancurti luancurti merged commit 21700e7 into lugg:master Jul 1, 2021
@jkey5stones
Copy link

@luancurti would it be possible to get a patch release containing this fix?

@jspizziri
Copy link

@luancurti would love to see a patch release with this, as otherwise we're effectively forced to downgrade to npm 6 to use this package.

@arcollector
Copy link

please could you update the npm version to reflect this change?

@luancurti
Copy link
Collaborator

Sry for the delay!

@Mcculloughj
Copy link

{
"os": [
"!win32"
]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native-windows as a peer dep might not be needed?
6 participants