-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /api/ctf/start
and /api/ctf/stop
routes
#5
Conversation
Not sure why mypy is considering |
Also run, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, except the docker client being initialised before the app runs, in the future it might break if someone decides to change the eventloop, but we can ignore that if it works rn
oh yah, get atleast 3.11 to pass before merging, for any type issues you can't resolve after #7 lemme know I will do a PR to your fork |
db_url=config.db_url, | ||
modules={"models": ["pwncore.models"]} | ||
) | ||
await Tortoise.generate_schemas() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need safe=True here?
""" | ||
return {"status": "CTF started"} | ||
if config.development: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just mark this for future removal with a comment
This PR adds the following:
config.py
I could not add tests cause I was unable to figure out how to run asynchronous tests with pytest.