Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing with trunk ruby 2.5.0dev (2017-10-10 trunk 60155) [x64-mingw32] #30

Closed
MSP-Greg opened this issue Oct 11, 2017 · 3 comments
Closed

Testing with trunk ruby 2.5.0dev (2017-10-10 trunk 60155) [x64-mingw32] #30

MSP-Greg opened this issue Oct 11, 2017 · 3 comments

Comments

@MSP-Greg
Copy link

Luis,

Just forked this, and added trunk to Appveyor. Had two failures that looked version related.
https://ci.appveyor.com/project/MSP-Greg/gem-compiler/build/job/62q08u00mycg9j9o

Hope things are well...
luislavena added a commit that referenced this issue Oct 11, 2017
@luislavena
Use correct RubyGems exception on tests
9145fb6 
Recent RubyGems changed exception hierarchy when requirements aren't
met. Instead of raising original `Gem::InstallError` it now raises
`Gem::RuntimeRequirementNotMetError` (more specific).

Adapt tests to workaround this and be backward compatible.

Fixes #30
@luislavena luislavena mentioned this issue Oct 11, 2017
Merged
@luislavena
Copy link
Owner

Hello @MSP-Greg, thank you for your report!

I've created #31 to solve this, can you run your tests against that branch?

Thank you.

PS: Not sure if RubyInstaller provides an official trunk artifact, but that will be great to add to AppVeyor matrix (like ruby-head on Travis) 😉

@MSP-Greg
Copy link
Author

Thanks for the quick fix. That passed, AV test.

Re trunk & 'official', you may recall that I've been building MSYS2/MinGW trunk for quite a while (before RI2), and I was always concentrated on repeatable testing. RI2 / Lars was focused on the runtime and 2.4.

Using it is your choice. ruby/spec and rubygems/rubygems are using it, and more soon. I'ts a rolling build done twice a day, I may cancel a build if there's only a real commit or two (ignoring svn commits). Some history here.

Previously, I built locally and pushed to BinTray. As noted, now it's built on AV and saved as an artifact. Includes RI2 runtime files.

@luislavena
Copy link
Owner

Thanks @MSP-Greg, I honestly don't remember a lot of RubyInstaller 😄

re: trunk builds, interesting seeing adoption and thanks for the links, will consider adding that to this gem build process.

Once again, thank you for your report and your contributions to Ruby on Windows!
❤️ ❤️ ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luislavena @MSP-Greg