Perform noop trying to compile non-compilable gems #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer raise exceptions when executed against gems already
pre-compiled or gems that have no extensions.
This aims to ease simple automation scenarios.
$ gem compile addressable-2.7.0.gem
Unpacking gem: 'addressable-2.7.0' in temporary directory...
There are no extensions to build on this gem file. Done.
$ gem compile unf_ext-0.0.7.6-x86_64-linux.gem
Unpacking gem: 'unf_ext-0.0.7.6-x86_64-linux' in temporary directory...
The gem file seems to be compiled already. Done.
In both cases, exit code is zero (0).
Fixes #38
luislavena
added a commit
that referenced
this pull request
Apr 5, 2020
Do not indicate *Done* during a noop scenario (Eg. gem already compiled, gem without extensions). State that the gem was *skipped* instead. Ref #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer raise exceptions when executed against gems already pre-compiled or gems that have no extensions.
This aims to ease simple automation scenarios.
In both cases, exit code is zero (0).
Fixes #38