-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 6 brokes layout in Safari #36
Comments
Damn.. it shouldn't make difference. I guess they're right, safari is the new IE 😝 |
Definitely, Safari is getting there. The bug is even in the newest 10.1. I am not sure if I am able to send PR, I have never worked on postcss plugin. 😟 But it seems to me, it's all about this line. So I will try it. |
@Kout just show what your expected and actually and i can do PR |
Thanks @evilebottnawi very appreciated, I am currently very busy and the issue needs proper testing to prevent any unexpected behaviour in other browsers. The issue is limited to I am testing on virtualized IE11 (vie modern.ie) and the browser acts funny, changing the property in devTools fixes is it up, hower same value in source CSS has no effect. Safari I test on BrowserStack, and there it seems, Safari likes all variants (short or long), but not 0% for I am afraid, I see no combination to satisfy all browsers at once. |
Hi, glad this problem has been found, spent too much time searching where this bug was coming from! Good work! |
How about just omitting the basis value? I know that goes against the point of the plugin, but at the moment, it's broken without a satisfying solution for all browsers if the basis has to be strictly defined. |
fixed in version 3.1.0 |
It seems to me, that Safari does not like zero percentage unit. In column direction, this rule
.foo { flex: 1 1 0%; }
makes the element shrink completely, creating overlap. Changing
%
topx
helps to get desired behaviour.The text was updated successfully, but these errors were encountered: