Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Fix missing i18n strings #417

Closed
luizdepra opened this issue Sep 28, 2020 · 19 comments · Fixed by #454 or #456
Closed

[v2] Fix missing i18n strings #417

luizdepra opened this issue Sep 28, 2020 · 19 comments · Fixed by #454 or #456
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed v2

Comments

@luizdepra
Copy link
Owner

There are some missing translations. We should find them, translate and add default values.

@luizdepra luizdepra added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers v2 labels Sep 28, 2020
@clement-pannetier
Copy link
Contributor

clement-pannetier commented Oct 26, 2020

Recap of missing translations:

Help would be appreciated 👍.

@a1x42
Copy link
Contributor

a1x42 commented Oct 26, 2020

@clement-pannetier posts already exists for Slovak, I believe. Or am I missing something?

@clement-pannetier
Copy link
Contributor

@clement-pannetier posts already exists for Slovak, I believe. Or am I missing something?

@a1x42, I don't see [posts] inside the sk.toml file.

@a1x42
Copy link
Contributor

a1x42 commented Oct 26, 2020

@clement-pannetier lol, classic case of pebkac! it exists only in my fork! ;-)

@sdwolfz
Copy link
Contributor

sdwolfz commented Oct 26, 2020

I'm confused, which entries are actually missing from the translation files? (I can submit the Romanian one no problem, just need to know what is needed)

Would it be just...

[posts]
other = "Articole"

... or are there others?

@clement-pannetier
Copy link
Contributor

I'm confused, which entries are actually missing from the translation files? (I can submit the Romanian one no problem, just need to know what is needed)

Would it be just...

[posts]
other = "Articole"

... or are there others?

Hi @sdwolfz, you also need to add see_also + author i18n translations.

@josephting
Copy link
Contributor

josephting commented Oct 27, 2020

@clement-pannetier I don't see posts being used anywhere. Can you explain why we need to add that?
I need to see an example of how it's being used before I can translate it properly.

@clement-pannetier
Copy link
Contributor

@clement-pannetier I don't see posts being used anywhere. Can you explain why we need to add that?
I need to see an example of how it's being used before I can translate it properly.

@josephting, this theme uses one content type, posts. When you go to <url>/posts (assuming you have a posts folder inside content), there is a h1 element (Posts) that need to be translated. If we add another content type, for example "Projects", this one should be translated too, etc...

@luizdepra
Copy link
Owner Author

Closed by accident.

@luizdepra luizdepra reopened this Oct 27, 2020
luizdepra pushed a commit that referenced this issue Oct 27, 2020
@luizdepra
Copy link
Owner Author

Stop closing this issue automatically, Github. xD

@luizdepra luizdepra reopened this Oct 27, 2020
@luizdepra
Copy link
Owner Author

luizdepra commented Oct 27, 2020

Guys, I just have updated the en.toml and pt-br.toml with all the missing translation. You can use them as base for other translations.

@clement-pannetier, thanks for researching every missing translation and pinging people to help.

@luizdepra
Copy link
Owner Author

Another thing, I think that the category, tag and series translations are no working. Maybe we'll need to add the plural form translation for these words.

@clement-pannetier
Copy link
Contributor

@luizdepra Also noticed that I made a typo in the wiki, I wrote "Hugarian" instead of "Hungarian". Two in a row, wow 🤯.

@luizdepra
Copy link
Owner Author

Fixed, @clement-pannetier. xD

@josephting
Copy link
Contributor

Stop closing this issue automatically, Github. xD

lol that's why I made it like this in #455 to not trigger auto closing 😅

Resolves one of the item in #417

@clement-pannetier
Copy link
Contributor

Another thing, I think that the category, tag and series translations are no working. Maybe we'll need to add the plural form translation for these words.

@luizdepra, I'm working on that. Do you want to open a new issue ? If you remember, I started to do it when I worked on the projects archetype here #323.

@luizdepra
Copy link
Owner Author

@clement-pannetier I think we could make the fix based on all the already translated texts and ask for people's review. But, sure, I should create another issue.

luizdepra pushed a commit that referenced this issue Feb 26, 2021
@RobertoGongora RobertoGongora mentioned this issue Apr 12, 2021
8 tasks
wlemuel pushed a commit to wlemuel/hugo-coder that referenced this issue Jun 22, 2021
@MiWeiss MiWeiss mentioned this issue Sep 5, 2021
8 tasks
@tobiasehlert
Copy link
Contributor

@clement-pannetier, I've added the Swedish translation in #551. If there is something more missing, please let me know.

Looks also like the German translation (done in #598) and Malay (done in #641) can be ticket off :)

@luizdepra
Copy link
Owner Author

There are still some missing translation. I'm going to open another issue to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed v2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants