Fix disqus background in dark mode. #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaotianxt
force-pushed
the
fix/disqus-background
branch
from
2007d00
to
af91f68
Compare
xiaotianxt
force-pushed
the
fix/disqus-background
branch
from
af91f68
to
85caab4
Compare
luizdepra
reviewed
Nov 28, 2022
|
Nice. Thank you. :) |
luizdepra
approved these changes
Nov 28, 2022
eshack94
pushed a commit
to eshack94/hugo-coder
that referenced
this pull request
Dec 21, 2022
### Prerequisites - [x] This pull request fixes a bug. - [x] This pull request adds a feature. - [ ] This pull request introduces breaking change. ### Description This PR fixes the bug about disqus iframe background in dark mode, it also fix another bug when switching color mode. Before: <img width="881" alt="opaque background in dark mode" src="https://user-images.githubusercontent.com/17041194/202862887-720dbb82-f0c8-4a24-97fd-78baef2a7cb4.png"> After: <img width="883" alt="CleanShot 2022-11-20 at 01 12 52@2x" src="https://user-images.githubusercontent.com/17041194/202863146-d5a246a7-bbe5-4bef-9687-883ce33f5b1a.png"> #### Why this happens The problem is widely discussed [here](w3c/csswg-drafts#4772). >If the color scheme of an iframe differs from embedding document, iframe gets an opaque canvas bg appropriate to its color scheme. So I made two fixes: 1. Add `color-scheme: light` CSS property for disqus `iframe`, this creates a transparent background and fixes the opaque issue. 2. Add `themeChanged` event to notice disqus comments board refresh when the theme change, this fixes the opaque problem when you switch the mode. #### Reference I've been working on this issue for a whole night and the fixing idea was strongly inspired by [Sergeyski's Blog](https://sergeyski.com/css-color-scheme-and-iframes-lessons-learned-from-disqus-background-bug/). ### Issues Resolved Fixes luizdepra#722.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR fixes the bug about disqus iframe background in dark mode, it also fix another bug when switching color mode.
Before:
After:
Why this happens
The problem is widely discussed here.
So I made two fixes:
color-scheme: lightCSS property for disqusiframe, this creates a transparent background and fixes the opaque issue.themeChangedevent to notice disqus comments board refresh when the theme change, this fixes the opaque problem when you switch the mode.Reference
I've been working on this issue for a whole night and the fixing idea was strongly inspired by Sergeyski's Blog.
Issues Resolved
Fixes #722.