Fix blog post pagination token padding issue #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...based on [1]. I am by no means a web developer expert these days, but adding `display: flex` seem to ignore the whitespace. Also ChatGPT tols me to add `justify-content: center` to make the `<ul>` element presented centered. This commit does _not_ fix [2], but it recreates the issue for `localhost` (`hugo server serve`) such that I can actually fix the bug. [1] https://stackoverflow.com/a/14173761 [2] luizdepra#837
This fixes [1]. [1] luizdepra#837
...as per pull request template.
...as per pull request template.
JensRantil
changed the title
JensRantil
commented
Nov 26, 2023
| } | ||
| margin: 0; | ||
| text-align: center; | ||
| width: 2.2rem; |
There was a problem hiding this comment.
FYI, this width was selected rather arbitrary. This is what the current pagination looks like:
luizdepra
previously approved these changes
Nov 29, 2023
luizdepra
approved these changes
Nov 29, 2023
JensRantil
added a commit
to JensRantil/jensrantil.github.io
that referenced
this pull request
Feb 16, 2024
JensRantil
added a commit
to JensRantil/jensrantil.github.io
that referenced
this pull request
Feb 16, 2024
JensRantil
added a commit
to JensRantil/jensrantil.github.io
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Put an
xinto the box(es) that apply:Description
It fixes lack of padding for the pagination tokens when listing blog posts. Please review the PR commit by commit.
Issues Resolved
Checklist
Put an
xinto the box(es) that apply:General
#<ISSUE_NO>if applicableResources
make releaseto regenerate all CSS filesContributors
CONTRIBUTORS.mdif you aren't on it already