Make custom matcher regexp DOTALL #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@lukas-krecan review plz :-) |
EDbarvinsky
force-pushed
the
dotall_custom_matcher_regexp
branch
from
1541899
to
b83fd47
Compare
EDbarvinsky
commented
Mar 23, 2023
| @@ -216,6 +220,13 @@ void shouldSeeExpectedSource() { | |||
| assertThat(listener.getExpectedSource(), equalTo(singletonMap("test", "1"))); | |||
| } | |||
|
|
|||
| @Test | |||
| void shouldMatchWithLineSeparatorCustomMatcher() { | |||
There was a problem hiding this comment.
or would be better to update content of test AllAssertJTest, what do you think?
4 tasks
|
Looks good, thanks. I was thinking about an easy way how to apply DOTALL only on the second dot, but it would not be that easy. Actually, the first dot should not have been a dot, but can't change it without breaking backwards compatibility. |
|
Released as 2.37.0 |
|
wow! How fast. Tnx :-) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have face an issue, that custom matcher fails comparison in case if input parameter contains line terminators.
To make
(.*)match everything I suggest to update current regexp to be DOTALLif you need more appropriate example, please take a look here