Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qt logo #128

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Add Qt logo #128

merged 2 commits into from
Apr 2, 2024

Conversation

torarnv
Copy link
Contributor

@torarnv torarnv commented Mar 18, 2024

No description provided.

Copy link
Collaborator

@Finii Finii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This point in in fact two points on top of each other:

image

image

Source and license of the svg would be nice.

@torarnv
Copy link
Contributor Author

torarnv commented Mar 18, 2024

I am an employee of The Qt Company

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

Does the original have the same issue with the point?

It seems so 😬

image
Illustrator file in Inkscape, after moving one point by hand

But I (or whoever merges this) can easily just delete the point.

Does Qt qualify as open source thing?
Seems so (Wikipedia entry):

image

@torarnv
Copy link
Contributor Author

torarnv commented Mar 18, 2024

But I (or whoever merges this) can easily just delete the point.

Is that necessary? Can't we keep the SVG as is? Is it a problem that two points overlap?

If we remove the additional point, is it not possible that some SVG renderers may not "complete" the path, and miss a segment of the logo?

Does Qt qualify as open source thing?

Qt is an open source project, licensed under both open source licenses and commercial license by The Qt Company.

@Finii Finii added the Ready ⛱ Ready to be pulled label Mar 18, 2024
@torarnv
Copy link
Contributor Author

torarnv commented Mar 18, 2024

Thanks @Finii !!

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

If we remove the additional point, is it not possible that some SVG renderers may not "complete" the path, and miss a segment of the logo?

No, the other closed paths also do not have double points ;-)

I'm not sure might even be that fontforge would remove that point anyhow.
Nerdfonts for sure would ;-)

@torarnv
Copy link
Contributor Author

torarnv commented Mar 18, 2024

If we remove the additional point, is it not possible that some SVG renderers may not "complete" the path, and miss a segment of the logo?

No, the other closed paths also do not have double points ;-)

I'm not sure might even be that fontforge would remove that point anyhow. Nerdfonts for sure would ;-)

Thanks for the explanation :)

@Finii
Copy link
Collaborator

Finii commented Mar 18, 2024

Note to the merger:

README is missing, but as we have a parallel 'almost ready' PR pending and still no automatic codepoint allocation on merge the merge would fail anyhow for one of the PRs.

@Finii Finii requested a review from hasecilu March 18, 2024 11:36
Copy link
Collaborator

@hasecilu hasecilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check the svg and looks correct.
A usecase for this glyph could be to be used as icon on eza for .qss & .qrc files.

@Finii Finii merged commit 198b2ee into lukas-w:master Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logo-request Ready ⛱ Ready to be pulled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants