Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added KDE products' logos. #78

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Added KDE products' logos. #78

merged 2 commits into from
Nov 14, 2023

Conversation

AuraHerreroRuiz
Copy link
Contributor

  • Added KDE Plasma, KDE Neon and Kubuntu logos.
  • Compiled font with new logos.
  • Updated README.md

@Finii
Copy link
Collaborator

Finii commented Sep 30, 2022

The icons.tsv file is not updated; the way the fonts are compiled changed in the meanwhile, it seems.

@hasecilu hasecilu mentioned this pull request May 16, 2023
Merged
@AuraHerreroRuiz @Finii
Added KDE projects' logos
59adaf0 
Added KDE Plasma, KDE Neon and Kubuntu logos.

Compiled font with new logos.

Updated README.md

[note]
Adapted to new readme style and release mechanism by Finii.
@Finii
Copy link
Collaborator

Finii commented Nov 14, 2023

Adapted to new repo (since 1.0.0) layout.
Almost everything is automated. README.md manually altered to indicate coming icons. That will be overwritten automatically on release.

Force push.

@Finii
Kubuntu inv: Simplify svg
6995014 
[why]
The svg contains a circle object. That ends up as extra path in the
fonts.
Fonts only know paths so fontforge needs to convert it.

[how]
Transform thew circle to a path.
Combine all path to one path.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Nov 14, 2023

The Kubuntu-Inverse svg was not safe for font usage. Here how it has been converted to all-path by the fontforge install (left) and what I changed (right):

image

The old/left svg consists of the cogwheel thing with a triangular hub and on top of that drawn a circle object.
The problem is that this creates an overlapping path and depending on rendering engine it will either be renedered full or as hollow.

Most reliable results can only be achieved if the svg is all-paths and only one path is best.

@Finii
Copy link
Collaborator

Finii commented Nov 14, 2023

Thanks for the PR!

@Finii Finii merged commit 8aaac35 into lukas-w:master Nov 14, 2023
@Finii Finii mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AuraHerreroRuiz @Finii