Add Codeberg Logo #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
|
The icon is the special purpose icon from the official icon kit. |
Finii
reviewed
Nov 14, 2023
README.md
Outdated
| @@ -42,6 +42,7 @@ Available logos are: | |||
| | Artix Linux | `fl-artix` | `<i class="fl-artix"></i>` | `0xf31f` | <img src="vectors/artix.svg" width="24"> | |||
| | Budgie | `fl-budgie` | `<i class="fl-budgie"></i>` | `0xf320` | <img src="vectors/budgie.svg" width="24"> | |||
| | CentOS | `fl-centos` | `<i class="fl-centos"></i>` | `0xf304` | <img src="vectors/centos.svg" width="24"> | |||
| | Codeberg | `fl-codeberg` | `<i class="fl-codeberg"></i>` | `0xf330` | <img src="vectors/codeberg.svg" width="24"> | |||
There was a problem hiding this comment.
If we pull this the README.md change will be immediately visible, although the icon is not yet in the release.
This can lead to confusion.
(The gh-pages are very old.)
[why] When we add icons one by one we usually already assign a codepoint and change the readme page, but the actual release did not happen yet. So documenation and real files get out of sync. [how] Mark the added but not released icons in the readme table. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
Thanks for the nice PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Logo for codeberg.org