Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support image replace #27

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

TeCHiScy
Copy link
Contributor

@TeCHiScy TeCHiScy commented Apr 19, 2024

  • read word/media/* in parseArchive
  • save media files changes in Write
  • add testcases for image replacement (inserted lenna image inside docx, and replace it with cameraman image)
  • update README to include image replace usage

closes #15

@TeCHiScy
Copy link
Contributor Author

Hi, @lukasjarosch,
the PR is finished, please review, thanks.

- Read word/media/* in `parseArchive`
- Save media file changes in `Write`
- Added testcases for image replacement
- Update README to include image replace usage

closes lukasjarosch#15
@arieslee
Copy link

nice job

@mateus4k
Copy link

Nice improvement!

@lukasjarosch lukasjarosch merged commit fe742ed into lukasjarosch:develop Jul 31, 2024
@lukasjarosch
Copy link
Owner

lukasjarosch commented Jul 31, 2024

Thank you very much for this very cool solution, love it ❤️
Sorry that the notification slipped through on my side, please accept my cookie 🍪

Edit: Since you added a feature, this could also be considered v0.5.0 🚀 https://github.com/lukasjarosch/go-docx/releases/tag/v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I hope that this library will be able to replace images in the future.
4 participants