Store prometheus http handlers instead of recreating them for every request #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the http handler to store the internal
http.Handlerobject for every filter combination, instead of recreating them for every request.The node exporter only stores the unfiltered one, and recreates the filtered ones, if they are needed.
I believe it is fine to store the filtered ones in this project, because having only 3 collectors means there are 7 filter combinations(plus the unfiltered one) at most.
However I would be fine with recreating the filtered ones, if you believe this isn't worth the additional RAM it uses.
Closes #22