Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic upload on save stopped working #267

Closed
felix007 opened this issue Dec 5, 2018 · 25 comments
Closed

automatic upload on save stopped working #267

felix007 opened this issue Dec 5, 2018 · 25 comments

Comments

@felix007
Copy link

felix007 commented Dec 5, 2018

automatic upload on save stopped working after 0.3.7 update.
please check it worked great yesterday

using
mac 10.11.6
vscode Version 1.29.1 (1.29.1)
thank you

@wolfcreative
Copy link

Hey. I had such a problem. I decided to install it with the old version (https://marketplace.visualstudio.com/_apis/public/gallery/publishers/lukasz-wronski/vsextensions/ftp-sync/0.3.5/vspackage)

Do not forget to disable auto-update extensions.

@dalecosp
Copy link

dalecosp commented Dec 5, 2018

Looks like it's a similar issue to #154 . A workaround there is to populate the array inside "generatedFiles" in ftp-sync.json, and it works, in my case, for things like ".js", ".php" ... the down-side, for me, being that I can't figure out what to put there for files with NO extension ... :(

@felix007
Copy link
Author

felix007 commented Dec 5, 2018

Thank you wolfcreative for the link of the old version!
now it's working again.
can you tell me how to find links to older versions of extensions? this will be a great future saver.

dalecosp, i have the right settings and it's not saving after the 0.3.7 update.
see how i"m using the details in the jason file.

"ignore": [
"\.vscode",
"\.git",
"\.DS_Store"
],
"generatedFiles": {
"uploadOnSave": true,
"extensionsToInclude": [".php", ".css", ".js", ".scss", ".css.map"],
"path": ""
}

@wolfcreative
Copy link

wolfcreative commented Dec 5, 2018

@felix007 i will explain step by step:

  1. Open the extension page in the marketplace.
  2. Find the right version in the "Version history".
  3. Go back up and find the "Download Extension" button (the joke is that this is not a link, wtf MS).
  4. In the browser downloads menu, click on the extension with the right mouse button and "copy link" (I work through firefox).

What to do next makes no sense to explain.

@felix007
Copy link
Author

felix007 commented Dec 5, 2018

@wolfcreative thank you very much!

@ithan1985
Copy link

the best way is reinstall vscode to fix the problem

@felix007
Copy link
Author

felix007 commented Dec 6, 2018

first thing iv"e done. doesn't work for me.

@GASOLINE
Copy link

GASOLINE commented Dec 6, 2018

Also stopped working here. Disappointing. Hope it will be fixed because this is a really nice extension and feature. Don't know why MS does not include it as a standard feature in VSC.

@NajSurf
Copy link
Collaborator

NajSurf commented Dec 6, 2018

Please check the latest version for a fix #268. It should be working now

@dalecosp If you want to include a file with no extension you simply add empty "" to the extensionsToInclude array. There is kind of a downside to it tho, because adding "" also makes you include files with all extensions.

@felix007
Copy link
Author

felix007 commented Dec 7, 2018

@NajSurf i"m not sure what to do. updated to 0.3.7 still upload on save not working. deleted extension and installed fresh no change.
do i need to install a different version?

@NajSurf
Copy link
Collaborator

NajSurf commented Dec 7, 2018

I've just published new fixed version to the marketplace. generatedFiles was messing with uploadOnSave function. Now both functions work as planned and the problem is not occuring anymore. I'll check soon if it uploads properly when files are generated automatically by application.

Also you can check the latest merge for more info #269

@felix007
Copy link
Author

felix007 commented Dec 7, 2018

It's working again!
@NajSurf Thank you for the best vs extension!

@NajSurf
Copy link
Collaborator

NajSurf commented Dec 7, 2018

That is very good to hear :)

@felix007
Copy link
Author

felix007 commented Dec 8, 2018

Hi @NajSurf their is still a bug that is not uploading files from css folder = css/style.css files that are generated from scss.
when i install 0.3.5 it is working great.
can you check that?
Thank you

my json file is
{
"remotePath": "remote path",
"host": "host name",
"username": "user",
"password": "password",
"port": 22,
"secure": false,
"protocol": "sftp",
"uploadOnSave": true,
"passive": false,
"debug": false,
"privateKeyPath": null,
"passphrase": null,
"ignore": [
"\.vscode",
"\.git",
"\.DS_Store"
],
"generatedFiles": {
"uploadOnSave": true,
"extensionsToInclude": [".php", ".css", ".js", ".scss", ".css.map"],
"path": ""
}
}

@NajSurf
Copy link
Collaborator

NajSurf commented Dec 10, 2018

{
"remotePath": "remote path",
"host": "host name",
"username": "user",
"password": "password",
"port": 22,
"secure": false,
"protocol": "sftp",
"uploadOnSave": true,
"passive": false,
"debug": false,
"privateKeyPath": null,
"passphrase": null,
"ignore": [
".vscode",
".git",
".DS_Store"
],
"generatedFiles": {
"uploadOnSave": true, <---- this is no longer necessary, just delete that line.
"extensionsToInclude": [".php", ".css", ".js", ".scss", ".css.map"],
"path": "" <---- here you should provide the path to the place where generated files are, if u set this to your root folder/workspace folder then it should upload every file in it. If it's not set it wont work. I think this can be the problem.
}
}

@felix007
Copy link
Author

all the files when saved are being uploaded.. including - file.scss
only the .css files that are generated into css folder are not uploaded.
every thing worked and still working in 0.3.5.

@NajSurf
Copy link
Collaborator

NajSurf commented Dec 10, 2018

I'll try to reproduce it when I have some free time.

@felix007
Copy link
Author

Thank you

@NajSurf
Copy link
Collaborator

NajSurf commented Dec 10, 2018

Please download latest version from this github repository and check if that worked for you.

@felix007
Copy link
Author

I"ll be happy to do so but i don't know how ):
to download the zip file and change the extension to vsix?

@NajSurf
Copy link
Collaborator

NajSurf commented Dec 10, 2018

  1. Download zip
  2. Unpack it
  3. Go to .vscode/extensions - ".vscode" is a hidden folder
  4. Replace the ftp sync folder with the folder inside of the unpacked folder

@felix007
Copy link
Author

Great it's working again!
thank you

@NajSurf
Copy link
Collaborator

NajSurf commented Dec 11, 2018

Great :) I'll leave the issue open for couple more days if any problem occures again.

@dalecosp
Copy link

Confirm, working here as well. Thank you.

@NajSurf NajSurf closed this as completed Dec 26, 2018
@GASOLINE
Copy link

{
"remotePath": "remote path",
"host": "host name",
"username": "user",
"password": "password",
"port": 22,
"secure": false,
"protocol": "sftp",
"uploadOnSave": true,
"passive": false,
"debug": false,
"privateKeyPath": null,
"passphrase": null,
"ignore": [
".vscode",
".git",
".DS_Store"
],
"generatedFiles": {
"uploadOnSave": true, <---- this is no longer necessary, just delete that line.
"extensionsToInclude": [".php", ".css", ".js", ".scss", ".css.map"],
"path": "" <---- here you should provide the path to the place where generated files are, if u set this to your root folder/workspace folder then it should upload every file in it. If it's not set it wont work. I think this can be the problem.
}
}

If i set path like /build it works, but only for that folder. Than my other files in / are ignored. Confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants