wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet

Just the actual fix Github-Pull: bitcoin#18671 Rebased-From: fa60afc (partial)
luke-jr · May 5, 2020 · 295027c · 295027c
1 parent a840dab
commit 295027c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/wallet/rpcdump.cpp b/src/wallet/rpcdump.cpp
@@ -752,6 +752,10 @@ UniValue dumpwallet(const JSONRPCRequest& request)
 
     LegacyScriptPubKeyMan& spk_man = EnsureLegacyScriptPubKeyMan(*wallet);
 
+    // Make sure the results are valid at least up to the most recent block
+    // the user could have gotten from another RPC command prior to now
+    wallet->BlockUntilSyncedToCurrentChain();
+
     auto locked_chain = pwallet->chain().lock();
     LOCK2(pwallet->cs_wallet, spk_man.cs_KeyStore);