-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: throw an error when there are no controllers found #1303
Conversation
quite some dependency updates needed to get this running again.
should we maybe move that to a seperat PR? |
as a side effect this will also temporary fix any issues with ts4.8 (as 4.7 will be used ;-))
Don't think this is only related to win (I hope) |
It seems though it's only related to windows, it finishes successfully on linux and mac on the github actions (locally also on linux, tests are running fine). I guess it has something todo with the paths, as on windows the allFiles array is empty:
|
7719215
to
77cf57a
Compare
77cf57a
to
25d7844
Compare
b88c1ff
to
35a892b
Compare
Still fails on windows somehow with superagent.
first was thinking this could be related ladjs/supertest#617 but there is actually no http2.. kinda hard to figure it out on a non-windows env... |
With the ts4.8 issue it turns out tsoa does not throw any kind of error if there are zero controllers found. Which makes it even a bit hard to find the issue in first place. To prevent this in the future I added a check that throws an Error if there are no controllers discovered.
All Submissions:
Closing issues
Put
closes #XXXX
(where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.potentially helps e.g. for #1301
If this is a new feature submission:
Potential Problems With The Approach
In my opinion it doesn't make sense to use tsoa without any controllers, but maybe I'm missing some special use cases?
Test plan
the added test catches the expected error when there are no controllers