Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Closing issues
closes #668
Related Issues
relates to #479
If this is a new feature submission:
Potential Problems With The Approach
One issue with this approach is that typescript when compiled with strictNullChecks, appears to not allow enums with null value. This feels like a typescript bug to me but I haven't been able to track it down.
Test plan
I updated existing unit tests to cover the new behavior. I additionally experiment with code generated with the new changes when possible. Code generation for oneOfs is not currently working with typescript-fetch generator.