New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory optimization or bug? the 4 PB limit of Hasher.stack #23

Open

glycerine opened this issue Feb 1, 2025 · 0 comments

glycerine commented Feb 1, 2025

type Hasher struct {
    // log(n) set of Merkle subtree roots, at most one per height.                  
    stack   [64 - (guts.MaxSIMD + 10)][8]uint32

I think technically that should be log2(guts.MaxSIMD)==4,
instead of guts.MaxSIMD == 16, to get full 2^64-1 input support
that the spec requires.

Its an extra 12*32 = 384 bytes per Hasher (so from 1216 bytes -> 1536 bytes
for the stack), so probably not too expensive.

The text was updated successfully, but these errors were encountered:

glycerine pushed a commit to glycerine/blake3 that referenced this issue


          fix lukechampine#23

glycerine mentioned this issue

Parallel hashing for 6-9x speedup #24

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment