Fix(Types): Closer to Completion #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous typings from #11 was consistently unhappy whenever you tried to
ga.send()an event.Also, TS (apparently) can't do method overloading with value matching, so the way that
sendwas redefined didn't consistently work. It didn't allow forpageviewto skip its 2nd arg, and it would, by default, showEventArgsto all callers until you scrolled thru the list manually.I've fixed these edge cases after battling TS for a while, with help of friends.
Also changed the formatting of the info blocks so that they're consistent for each key.
@rand0me I'd appreciate it if you were able to take a look. Some of your docs were lost (eg,
"Max Length: ...") but the rest of it should look familiar. Thanks~!