-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix .d.ts #22
Fix .d.ts #22
Conversation
Hmm may I ask for your settings / a repro? What's published currently is working on my end |
Sure, I use typescript in a very strict mode tsconfig.json:
|
Thanks! I'll be back to my desk in a little bit and run through then. |
Oh. I just noticed your typeRoots config. I recommend you move your |
I'll try. |
I've run into this before -- was definitely annoying and unexpected 😅 |
:( |
Shit – you're right! I've got some serious double-checking to do in my projects~ I want to make some adjustments to your PR(s) but let's get this in. |
If you want, i can create a project in typescript(strict) for testing your libraries. |
Thanks :) I think my public stuff should be pretty easy to find & fix. I really meant my private things that followed the same pattern. Definitely feel free to open an issue on anything you see that I forgot though! |
These PRs inspired me to add type-definition management inside I probably won't make use of it inside dequal/klona, since they just need the |
Module declaration did not work because index.d.ts is not a rootType, so I created a declaration file for each mode.