make creation of http server by polka optional #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 20, 2018 12:42
tHAT OPTS doesN't EXIST If NOT Passed
ghost
commented
Jan 20, 2018
| @@ -30,7 +32,7 @@ class Polka extends Router { | |||
|
|
|||
| start(port, hostname) { | |||
| return new Promise((res, rej) => { | |||
| this.server.listen(port, hostname, err => err ? rej(err) : res()); | |||
| this.server ? this.server.listen(port, hostname, err => err ? rej(err) : res()) : rej(); | |||
There was a problem hiding this comment.
I am thinking of rej('internal server disabled by options')
ghost
mentioned this pull request
|
Hey, thanks! Will take some time to review as I figure out where I want Polka to go. For the record though, re: #12 (comment), you can already wrap Polka with your own HTTP(S) server. The underlying server is only used/running if you call Please see the |
|
I acknowledged that it only listens if start is called but it still creates http server each time new class is created under .server property and that floats without usage. |
ghost
closed this
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polka would create floating unused http server if people decided to use own like https or native written in C or other langs
by adding
{ createServer: true/false (default true) }option it allows to control creation of internal serverI wasn't sure what to include in start method promise rejection if server doesn't exist so I leave it for you to decide