break(url): handle decodes correctly; trim ParsedURL
properties
#165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the opportunity to make it a breaking change:
ParsedURL
interfaceparse
export instead of default functionTechnically, this means it's a breaking change for Polka too. Specifically, the
req.url
is no longer fully decoded.Now,
req.url
is the decodedreq.path
segment concatenated with the NOT-decodedreq.search
segment. Before this change, thereq.url
was comprised of a decodedreq.search
segment too... which often caused problems in userland.The raw, fully-encoded value is always still available as
req.originalUrl
... unless you change it.Lastly, revamped the
@polka/url
benchmarks and it looks like it got a bit of a speed boost too 🚀Closes #150