Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for the fix regarding wildcard imports #26

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

bnussman
Copy link
Contributor

@bnussman bnussman commented Mar 4, 2023

This use to work back in the day (1.0.1), but now this case fails.

Has something changed in the way these are resolved? I really don't see why this shouldn't work.

Please let me know if I'm misunderstanding or if this can be fixed 🥺

Screenshot 2023-03-03 at 11 46 19 PM

@bluwy
Copy link

bluwy commented Mar 4, 2023

Here's a repro showing that the test case added works in nodejs: https://stackblitz.com/edit/node-lzjbma?file=packages%2Fapp%2Findex.js (Run pnpm test)

lukeed added a commit that referenced this pull request Mar 6, 2023
@lukeed
Copy link
Owner

lukeed commented Mar 6, 2023

Solved by 5d9601d, thanks for test case!

@lukeed lukeed merged commit 1a0164d into lukeed:master Mar 6, 2023
@bnussman
Copy link
Contributor Author

bnussman commented Mar 6, 2023

Appreciate you @lukeed. Thank you

@bnussman bnussman changed the title Potential New Test Case Test case for the fix regarding wildcard imports Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants