Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev mode ignores dotfiles #51

Closed
sonicdoe opened this issue Feb 14, 2020 · 4 comments
Closed

Dev mode ignores dotfiles #51

sonicdoe opened this issue Feb 14, 2020 · 4 comments
Labels

Comments

@sonicdoe
Copy link

If dev mode is enabled, dotfiles is ignored.

For example, a file named .foo.txt is served in dev mode even if dotfiles is set to false.

@lukeed lukeed added the has fix label May 23, 2020
@lukeed
Copy link
Owner

lukeed commented May 23, 2020

Thanks for the report – this is fixed in next which will be promoted to 1.0 asap.

@lukeed
Copy link
Owner

lukeed commented Jun 10, 2020

Closed via #64

@lukeed lukeed closed this as completed Jun 10, 2020
@sonicdoe
Copy link
Author

I can still reproduce this with sirv v1.0.0. If I set dev to true and dotfiles to false, sirv serves a file named .foo.txt.

lukeed added a commit that referenced this issue Jun 17, 2020
@sonicdoe
Copy link
Author

sonicdoe commented Aug 4, 2020

@lukeed Thank you for adding some tests with d01fe72. However, the assertions in “should reject hidden files by default (dev: true)” aren’t executed because the catch block is never called. In fact, the status code is 200 OK for all three responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants