-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: also pass the name of the things to hooks #55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 3 3
Lines 305 305
=======================================
Hits 275 275
Misses 30 30
Continue to review full report at Codecov.
|
Hmm.. what about a Another option could be writing into |
Thanks for that @lukeed i think i've done it, and kinda "Lukey" with that crumbs array thingo. Let me know what you feel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to be applying some light renames
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. We discussed this a little bit & agreed that using special context
keys was the better way to go. It allows hooks and test handlers to maintain the same API & doesn't litter the Callback
signature with extra, conditional parameters.
@maraisr Would appreciate it if you were able to look over the changes & verify that they still match your expectations. Thanks!
ship it! 🚀 |
This PR aims to also pass through the name of either the suite or the test through to hooks.
This would aid in things like
playwright
and taking a screenshot after every test, and naming it the same as the test.