-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Native ESM Support #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all test files must be mjs - allows -r esm hook still, if wanted - does not work in < Node 12 Node 8-10 throw with `import()` immediately With `esm`, "native `require` cannot sideload `mjs` files"
- blocked by kpdecker/jsdiff#292 - will (finally) craft own diff library if unwilling to resolve
- avoids Node 8.x and 10.x syntax error
When invoking `node` directly on a test file, allow native `stderr` output error(s) to write to console, allowing Node to explain why _it_ aborted. Important for ESM adopters/transitions.
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage 89.89% 89.89%
=======================================
Files 3 3
Lines 297 297
=======================================
Hits 267 267
Misses 30 30
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7