Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parse): Add cwd default; return requires boolean #78

Merged
merged 4 commits into from
Dec 1, 2020
Merged

Conversation

lukeed
Copy link
Owner

@lukeed lukeed commented Nov 30, 2020

  • Fixes the types
  • Adds uvu/parse tests
  • Adds default to opts.cwd
  • Returns new requires boolean indicating whether or not -r/--require was defined
    Better here than doing it differently inside bin.js directly.

Related to #72 – but does not replace #73
We'll see what other conditions can still trigger ERR_UNKNOWN_FILE_EXTENSION error and go from there with concrete example(s). I suspect it's still possible to be thrown, but not sure exactly how. @tolu Let's keep both of your items open so that if/when any issues still arise, we already have a billboard and a springboard for them.

@lukeed lukeed merged commit 4288f22 into master Dec 1, 2020
@lukeed lukeed deleted the fix/parse branch December 1, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant