Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enhancements for file watcher (fs.watch) #37

Closed
wants to merge 1 commit into from
Closed

add enhancements for file watcher (fs.watch) #37

wants to merge 1 commit into from

Conversation

chiefjester
Copy link

@chiefjester
add enhancements for file watcher (fs.watch)
6fe8c3f 
- fixes lukejacksonn#36
- fs.watch recursive option is only supported on macOS and Windows (see https://nodejs.org/docs/latest/api/fs.html#fs_caveats)
- add node-watch as a thin wrapper for fs.watch
- node-watch author claims it's much faster and more memory efficient than fs.watch
@chiefjester chiefjester mentioned this pull request Jan 22, 2020
Closed
@lukejacksonn
Copy link
Owner

lukejacksonn commented Jan 23, 2020 •
edited
Loading

This is awesome stuff man. Thanks, I have written down some thoughts here #36 (comment) lmk what you think!

@lukejacksonn
Copy link
Owner

Going to close this now in favour of #39 which has been merged!

@chiefjester chiefjester deleted the watchFix branch February 11, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't detect change in nested files (on Linux)
2 participants
@chiefjester @lukejacksonn