Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement livereactload for hot loading #12

Merged
merged 6 commits into from
Feb 14, 2016
Merged

Conversation

lukemorton
Copy link
Owner

The aim of this pull request is to implement client side hot reloading. I'm running into a few issues and would love some help.

Recreate the problem

Follow these steps to recreate the problem.

  1. Clone this repo
  2. git checkout feature/hot-loading
  3. cd examples
  4. npm install && sudo npm link && republic dev
  5. Open http://localhost:3000 in browser
  6. Change text in examples/app/views/hello/world.jsx

The error

When attempting the above I get the following error:

Image showing stack trace

Expected outcome

Only the world.jsx file should be reloaded. I did not expect the parent files to be reloaded and as such redux and react router. How can I ensure only userland files (i.e. ones in their app directory not republic) are hot loaded?

Related links

lukemorton added a commit that referenced this pull request Feb 14, 2016
Implement livereactload for hot loading
@lukemorton lukemorton merged commit f3fdaa2 into master Feb 14, 2016
@lukemorton lukemorton deleted the feature/hot-loading branch February 14, 2016 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant