-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 New Crowdin updates #1511
🌐 New Crowdin updates #1511
Conversation
[ci skip]
[ci skip]
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
WalkthroughThis pull request enhances localization files for Spanish, Swedish, Danish, German, and Portuguese (Brazil) in the landing and web applications. It introduces new entries for user account management, quick blog and poll creation, and email verification processes. The updates aim to improve user experience by providing clearer instructions and options across various interface elements, ensuring that users have the necessary guidance for actions like logging in, registering, and managing their accounts. Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[ci skip]
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/emails/locales/sv/emails.json (1)
51-56
: Maintain consistent terminology across translations.The translations use "mejl" while other parts of the application use "e-post". Consider using consistent terminology:
- "changeEmailRequest_heading": "Verifera den nya mejladressen", + "changeEmailRequest_heading": "Verifiera den nya e-postadressen", - "changeEmailRequest_text2": "Tryck på knappen nedan för att slutföra förändringen:", + "changeEmailRequest_text2": "Tryck på knappen nedan för att slutföra ändringen:", - "changeEmailRequest_button": "Verifiera mejladressen", + "changeEmailRequest_button": "Verifiera e-postadressen", - "changeEmailRequest_subject": "Verifiera den nya mejladressen", + "changeEmailRequest_subject": "Verifiera den nya e-postadressen", - "changeEmailRequest_text1": "Vi har fått en förfrågan om att ändra mejladressen för ditt konto från <b>{{fromEmail}}</b> till <b>{{toEmail}}</b>." + "changeEmailRequest_text1": "Vi har fått en förfrågan om att ändra e-postadressen för ditt konto från <b>{{fromEmail}}</b> till <b>{{toEmail}}</b>."apps/web/public/locales/sv/app.json (1)
270-277
: Maintain consistent terminology across translations.The translations use "mejl" while other parts of the application use "e-post". Consider using consistent terminology:
- "emailChangeSuccess": "Lyckat byte av mejladress", + "emailChangeSuccess": "Lyckat byte av e-postadress", - "emailChangeSuccessDescription": "Din mejladress är uppdaterad", + "emailChangeSuccessDescription": "Din e-postadress är uppdaterad", - "emailChangeRequestSent": "Verifiera den nya mejladressen", + "emailChangeRequestSent": "Verifiera den nya e-postadressen", - "emailChangeRequestSentDescription": "För att slutföra ändringen, kolla i din mejl efter en verifieringslänk.", + "emailChangeRequestSentDescription": "För att slutföra ändringen, kolla i din e-post efter en verifieringslänk.", - "profileEmailAddress": "Mejladress", + "profileEmailAddress": "E-postadress", - "profileEmailAddressDescription": "Din mejladress används för att logga in på ditt konto" + "profileEmailAddressDescription": "Din e-postadress används för att logga in på ditt konto"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
apps/landing/public/locales/sv/common.json
(1 hunks)apps/landing/public/locales/sv/home.json
(1 hunks)apps/landing/public/locales/sv/pricing.json
(1 hunks)apps/web/public/locales/sv/app.json
(1 hunks)packages/emails/locales/sv/emails.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- apps/landing/public/locales/sv/pricing.json
🔇 Additional comments (3)
apps/landing/public/locales/sv/common.json (1)
26-28
: LGTM! Translations are accurate and consistent.The new translations for When2Meet alternative and meeting poll are grammatically correct and maintain consistency with the existing translations.
apps/landing/public/locales/sv/home.json (1)
29-29
: LGTM! SEO-friendly translations with consistent branding.The translations are well-structured and maintain proper SEO practices by including the brand name in meta titles. The scheduling poll title is clear and user-friendly.
Also applies to: 33-34
apps/web/public/locales/sv/app.json (1)
291-294
: LGTM! Clear and user-friendly verification flow messages.The translations for registration and login verification provide clear instructions and maintain a consistent user experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/web/public/locales/sv/app.json (2)
270-277
: Maintain consistent terminology for email-related translations.There's an inconsistency in terminology where new translations use "mejl" while existing translations use "e-post". Consider standardizing the terminology across all translations.
Consider updating these translations to use "e-post" consistently:
- "emailChangeSuccess": "Lyckat byte av mejladress" + "emailChangeSuccess": "Lyckat byte av e-postadress" - "emailChangeSuccessDescription": "Din mejladress är uppdaterad" + "emailChangeSuccessDescription": "Din e-postadress är uppdaterad" - "emailChangeRequestSent": "Verifiera den nya mejladressen" + "emailChangeRequestSent": "Verifiera den nya e-postadressen" - "emailChangeRequestSentDescription": "För att slutföra ändringen, kolla i din mejl efter en verifieringslänk." + "emailChangeRequestSentDescription": "För att slutföra ändringen, kolla i din e-post efter en verifieringslänk." - "profileEmailAddress": "Mejladress" + "profileEmailAddress": "E-postadress" - "profileEmailAddressDescription": "Din mejladress används för att logga in på ditt konto" + "profileEmailAddressDescription": "Din e-postadress används för att logga in på ditt konto"
291-294
: Maintain consistent terminology in verification messages.Continue the terminology standardization in the verification messages.
Consider these updates:
- "registerVerifyDescription": "Kolla i din mejl efter din verifieringskod" + "registerVerifyDescription": "Kolla i din e-post efter din verifieringskod" - "loginVerifyDescription": "Kolla i din mejl efter din verifieringskod" + "loginVerifyDescription": "Kolla i din e-post efter din verifieringskod"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
apps/landing/public/locales/sv/common.json
(1 hunks)apps/landing/public/locales/sv/home.json
(1 hunks)apps/landing/public/locales/sv/pricing.json
(1 hunks)apps/web/public/locales/sv/app.json
(1 hunks)packages/emails/locales/sv/emails.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- apps/landing/public/locales/sv/pricing.json
🔇 Additional comments (2)
apps/landing/public/locales/sv/common.json (1)
26-28
: LGTM! Translations are accurate and consistent.The new translations maintain consistency with the existing terminology and follow proper JSON syntax.
apps/landing/public/locales/sv/home.json (1)
29-29
: LGTM! Translations are well-integrated.The new translations maintain consistency with common.json and provide clear, natural-sounding Swedish text.
Also applies to: 33-34
[ci skip]
[ci skip]
[ci skip]
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/landing/public/locales/da/home.json
(1 hunks)apps/web/public/locales/da/app.json
(1 hunks)packages/emails/locales/da/emails.json
(1 hunks)
🔇 Additional comments (4)
apps/landing/public/locales/da/home.json (1)
42-43
: LGTM! Translations are consistent and well-formatted.The new and modified entries maintain consistent terminology and proper JSON formatting.
packages/emails/locales/da/emails.json (1)
50-56
: LGTM! Email change request translations are complete and well-structured.The translations maintain consistent terminology, proper variable interpolation, and HTML formatting.
apps/web/public/locales/da/app.json (2)
273-284
: LGTM! Remaining translations are consistent and well-formatted.The new translations for notifications, email changes, and authentication maintain consistent terminology and proper formatting.
Also applies to: 288-308
287-287
:⚠️ Potential issueFix unclosed HTML tag in translation string.
The login footer message contains an opening
<a>
tag but no closing tag.Apply this fix:
- "loginFooter": "Har du ikke en konto? <a>Tilmeld dig</a>", + "loginFooter": "Har du ikke en konto? <a>Tilmeld dig</a>",Likely invalid or redundant comment.
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/web/public/locales/pt-BR/app.json (1)
Minor inconsistency in login terminology translation
The translation shows good overall consistency, but there's a minor inconsistency in login-related terms:
- "login" (noun) is translated as informal "Logar"
- The verb form alternates between "faça login" and "entre"
Consider standardizing to more formal Portuguese:
- Change "Logar" to "Entrar" or "Iniciar sessão"
- Use "faça login" consistently for verb form
🔗 Analysis chain
Line range hint
1-308
: Verify translation consistency across the file.Let's check for consistent usage of key terms across the file.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for consistent translations of key terms # Function to search for variations of login/entrar echo "Checking login/entrar variations:" rg -i "\".*([Ll]ogin|[Ee]ntr[ea]r).*\"" apps/web/public/locales/pt-BR/app.json # Function to search for variations of account/conta echo -e "\nChecking account/conta variations:" rg -i "\".*[Cc]ont[aa].*\"" apps/web/public/locales/pt-BR/app.json # Function to search for variations of create/criar echo -e "\nChecking create/criar variations:" rg -i "\".*([Cc]riar|[Cc]rie).*\"" apps/web/public/locales/pt-BR/app.jsonLength of output: 4360
🧹 Nitpick comments (1)
apps/web/public/locales/pt-BR/app.json (1)
285-287
: Authentication flow translations look good but could use minor improvements.The translations are generally good, but there are a few suggestions for better consistency and clarity:
- Line 286:
continueWithProvider
uses double curly braces{{provider}}
while line 285 uses single curly braces{provider}
. This inconsistency could cause issues.- Line 291: "Login" should be "Entrar" to match line 293's context of "Bem-vindo(a)".
- "continueWithProvider": "Continuar com {{provider}}", + "continueWithProvider": "Continuar com {provider}", - "loginDescription": "Entre na sua conta para continuar", + "loginDescription": "Entre na sua conta para continuar",Also applies to: 290-295, 304-308
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/landing/public/locales/pt-BR/home.json
(1 hunks)apps/web/public/locales/pt-BR/app.json
(1 hunks)
🔇 Additional comments (3)
apps/landing/public/locales/pt-BR/home.json (2)
42-42
: LGTM! Clear and concise meta description.The translation effectively communicates the meeting poll feature's purpose while maintaining consistency with other meta descriptions.
43-43
: LGTM! Well-structured translation for the quick create feature.The translation "Apresentando o Crie Rápido" is grammatically correct and maintains consistency with the product's naming convention across other language files.
apps/web/public/locales/pt-BR/app.json (1)
296-303
: Quick actions translations are well-structured and clear.The translations effectively communicate the benefits of creating an account while maintaining a friendly tone. The hierarchy of information is logical, starting with the quick action description and following up with the benefits.
[ci skip]
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/public/locales/de/app.json (1)
285-286
: Consider consolidating similar provider continuation strings.There are two similar keys for continuing with a provider:
"continueWith": "Weiter mit {provider}", "continueWithProvider": "Weiter mit {{provider}}"They use different placeholder styles (
{provider}
vs{{provider}}
). Consider consolidating these to maintain consistency and reduce potential confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/public/locales/de/app.json
(4 hunks)
🔇 Additional comments (3)
apps/web/public/locales/de/app.json (3)
70-71
: LGTM! Improved consistency and grammar.The changes to time format labels and descriptions are more consistent with modern UI practices and provide better German grammar.
Also applies to: 163-163
251-251
: LGTM! Well-structured localization string.The time zone change detector message is properly formatted with HTML tags and includes the necessary placeholder for dynamic content.
296-301
: LGTM! Well-structured quick actions section.The quick actions section effectively communicates the benefits of account creation with clear, concise German translations.
Summary by CodeRabbit
Release Notes
New Features
Localization