Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1511

Merged
merged 17 commits into from
Jan 24, 2025
Merged

🌐 New Crowdin updates #1511

merged 17 commits into from
Jan 24, 2025

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Jan 22, 2025

Summary by CodeRabbit

Release Notes

  • New Features

    • Added quick blog creation feature.
    • Introduced quick group poll creation without login.
    • Enhanced account management with new login and registration flows.
    • Added email change request functionality with verification prompts.
  • Localization

    • Updated Spanish translations for landing and web app, including new descriptions for login, registration, and account verification processes.
    • Added Swedish translations for meeting scheduling and user account management.
    • Included new user guidance text for quick actions and account benefits.
    • Updated Danish translations for quick blog creation and email change requests.
    • Enhanced German translations related to account management and login processes.
    • Added Portuguese (Brazil) translations for account management and quick creation features.
    • Introduced new entries for email change requests and account management in multiple languages, enhancing user experience.

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 10:50pm
landing ⬜️ Skipped (Inspect) Jan 24, 2025 10:50pm

Copy link
Contributor

coderabbitai bot commented Jan 22, 2025

Walkthrough

This pull request enhances localization files for Spanish, Swedish, Danish, German, and Portuguese (Brazil) in the landing and web applications. It introduces new entries for user account management, quick blog and poll creation, and email verification processes. The updates aim to improve user experience by providing clearer instructions and options across various interface elements, ensuring that users have the necessary guidance for actions like logging in, registering, and managing their accounts.

Changes

File Changes
apps/landing/public/locales/es/home.json Added "quickCreateBlog" localization entry
apps/web/public/locales/es/app.json Multiple new entries added for login, registration, quick actions, and account creation descriptions
apps/landing/public/locales/sv/common.json Added "when2MeetAlternative" and "meetingPoll" entries
apps/landing/public/locales/sv/home.json Added "freeSchedulingPollTitle" and "when2meetAlternativeMetaTitle" entries
apps/landing/public/locales/sv/pricing.json Updated terminology for "whyUpgradeAnswer2"
apps/web/public/locales/sv/app.json Added multiple new entries related to email management and account processes
packages/emails/locales/sv/emails.json Added new entries for email change request notifications
apps/web/public/locales/da/app.json Added multiple new entries for account management and updated existing descriptions
apps/landing/public/locales/da/home.json Added "quickCreateBlog" localization entry
packages/emails/locales/da/emails.json Added new entries for email change request notifications
apps/web/public/locales/de/app.json Added new entries for account management and login processes
apps/landing/public/locales/pt-BR/home.json Added "quickCreateBlog" localization entry
apps/web/public/locales/pt-BR/app.json Multiple new entries added for account management and user login processes

Possibly related PRs

  • 🌐 New Crowdin updates #1150: This PR adds new localization keys related to quick blog creation in the Spanish app.json, which aligns with the new entry "quickCreateBlog": "Presentando Creación Rápida" added in the main PR.
  • 🌐 New Crowdin updates #1279: This PR includes changes to the Swedish localization files that enhance user engagement with scheduling tools, which aligns with the main PR's focus on quick blog creation.
  • 🌐 New Crowdin updates #1290: The addition of "quickCreateBlog" in this PR aligns with the changes that introduce similar entries for quick actions and blog creation across different languages.

Poem

🐰 A Rabbit's Localization Tale 🌈
Spanish words now dance with grace,
Quick polls and accounts find their place,
Buttons shimmer, descriptions bright,
User journeys take delightful flight!
Localization magic, oh so neat! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
packages/emails/locales/sv/emails.json (1)

51-56: Maintain consistent terminology across translations.

The translations use "mejl" while other parts of the application use "e-post". Consider using consistent terminology:

-  "changeEmailRequest_heading": "Verifera den nya mejladressen",
+  "changeEmailRequest_heading": "Verifiera den nya e-postadressen",
-  "changeEmailRequest_text2": "Tryck på knappen nedan för att slutföra förändringen:",
+  "changeEmailRequest_text2": "Tryck på knappen nedan för att slutföra ändringen:",
-  "changeEmailRequest_button": "Verifiera mejladressen",
+  "changeEmailRequest_button": "Verifiera e-postadressen",
-  "changeEmailRequest_subject": "Verifiera den nya mejladressen",
+  "changeEmailRequest_subject": "Verifiera den nya e-postadressen",
-  "changeEmailRequest_text1": "Vi har fått en förfrågan om att ändra mejladressen för ditt konto från <b>{{fromEmail}}</b> till <b>{{toEmail}}</b>."
+  "changeEmailRequest_text1": "Vi har fått en förfrågan om att ändra e-postadressen för ditt konto från <b>{{fromEmail}}</b> till <b>{{toEmail}}</b>."
apps/web/public/locales/sv/app.json (1)

270-277: Maintain consistent terminology across translations.

The translations use "mejl" while other parts of the application use "e-post". Consider using consistent terminology:

-  "emailChangeSuccess": "Lyckat byte av mejladress",
+  "emailChangeSuccess": "Lyckat byte av e-postadress",
-  "emailChangeSuccessDescription": "Din mejladress är uppdaterad",
+  "emailChangeSuccessDescription": "Din e-postadress är uppdaterad",
-  "emailChangeRequestSent": "Verifiera den nya mejladressen",
+  "emailChangeRequestSent": "Verifiera den nya e-postadressen",
-  "emailChangeRequestSentDescription": "För att slutföra ändringen, kolla i din mejl efter en verifieringslänk.",
+  "emailChangeRequestSentDescription": "För att slutföra ändringen, kolla i din e-post efter en verifieringslänk.",
-  "profileEmailAddress": "Mejladress",
+  "profileEmailAddress": "E-postadress",
-  "profileEmailAddressDescription": "Din mejladress används för att logga in på ditt konto"
+  "profileEmailAddressDescription": "Din e-postadress används för att logga in på ditt konto"
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a64898 and 2f034a2.

📒 Files selected for processing (5)
  • apps/landing/public/locales/sv/common.json (1 hunks)
  • apps/landing/public/locales/sv/home.json (1 hunks)
  • apps/landing/public/locales/sv/pricing.json (1 hunks)
  • apps/web/public/locales/sv/app.json (1 hunks)
  • packages/emails/locales/sv/emails.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/landing/public/locales/sv/pricing.json
🔇 Additional comments (3)
apps/landing/public/locales/sv/common.json (1)

26-28: LGTM! Translations are accurate and consistent.

The new translations for When2Meet alternative and meeting poll are grammatically correct and maintain consistency with the existing translations.

apps/landing/public/locales/sv/home.json (1)

29-29: LGTM! SEO-friendly translations with consistent branding.

The translations are well-structured and maintain proper SEO practices by including the brand name in meta titles. The scheduling poll title is clear and user-friendly.

Also applies to: 33-34

apps/web/public/locales/sv/app.json (1)

291-294: LGTM! Clear and user-friendly verification flow messages.

The translations for registration and login verification provide clear instructions and maintain a consistent user experience.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
apps/web/public/locales/sv/app.json (2)

270-277: Maintain consistent terminology for email-related translations.

There's an inconsistency in terminology where new translations use "mejl" while existing translations use "e-post". Consider standardizing the terminology across all translations.

Consider updating these translations to use "e-post" consistently:

-  "emailChangeSuccess": "Lyckat byte av mejladress"
+  "emailChangeSuccess": "Lyckat byte av e-postadress"
-  "emailChangeSuccessDescription": "Din mejladress är uppdaterad"
+  "emailChangeSuccessDescription": "Din e-postadress är uppdaterad"
-  "emailChangeRequestSent": "Verifiera den nya mejladressen"
+  "emailChangeRequestSent": "Verifiera den nya e-postadressen"
-  "emailChangeRequestSentDescription": "För att slutföra ändringen, kolla i din mejl efter en verifieringslänk."
+  "emailChangeRequestSentDescription": "För att slutföra ändringen, kolla i din e-post efter en verifieringslänk."
-  "profileEmailAddress": "Mejladress"
+  "profileEmailAddress": "E-postadress"
-  "profileEmailAddressDescription": "Din mejladress används för att logga in på ditt konto"
+  "profileEmailAddressDescription": "Din e-postadress används för att logga in på ditt konto"

291-294: Maintain consistent terminology in verification messages.

Continue the terminology standardization in the verification messages.

Consider these updates:

-  "registerVerifyDescription": "Kolla i din mejl efter din verifieringskod"
+  "registerVerifyDescription": "Kolla i din e-post efter din verifieringskod"
-  "loginVerifyDescription": "Kolla i din mejl efter din verifieringskod"
+  "loginVerifyDescription": "Kolla i din e-post efter din verifieringskod"
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a64898 and 2f034a2.

📒 Files selected for processing (5)
  • apps/landing/public/locales/sv/common.json (1 hunks)
  • apps/landing/public/locales/sv/home.json (1 hunks)
  • apps/landing/public/locales/sv/pricing.json (1 hunks)
  • apps/web/public/locales/sv/app.json (1 hunks)
  • packages/emails/locales/sv/emails.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/landing/public/locales/sv/pricing.json
🔇 Additional comments (2)
apps/landing/public/locales/sv/common.json (1)

26-28: LGTM! Translations are accurate and consistent.

The new translations maintain consistency with the existing terminology and follow proper JSON syntax.

apps/landing/public/locales/sv/home.json (1)

29-29: LGTM! Translations are well-integrated.

The new translations maintain consistency with common.json and provide clear, natural-sounding Swedish text.

Also applies to: 33-34

@vercel vercel bot temporarily deployed to Preview – landing January 23, 2025 15:22 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 512d8b1 and bb561c5.

📒 Files selected for processing (3)
  • apps/landing/public/locales/da/home.json (1 hunks)
  • apps/web/public/locales/da/app.json (1 hunks)
  • packages/emails/locales/da/emails.json (1 hunks)
🔇 Additional comments (4)
apps/landing/public/locales/da/home.json (1)

42-43: LGTM! Translations are consistent and well-formatted.

The new and modified entries maintain consistent terminology and proper JSON formatting.

packages/emails/locales/da/emails.json (1)

50-56: LGTM! Email change request translations are complete and well-structured.

The translations maintain consistent terminology, proper variable interpolation, and HTML formatting.

apps/web/public/locales/da/app.json (2)

273-284: LGTM! Remaining translations are consistent and well-formatted.

The new translations for notifications, email changes, and authentication maintain consistent terminology and proper formatting.

Also applies to: 288-308


287-287: ⚠️ Potential issue

Fix unclosed HTML tag in translation string.

The login footer message contains an opening <a> tag but no closing tag.

Apply this fix:

- "loginFooter": "Har du ikke en konto? <a>Tilmeld dig</a>",
+ "loginFooter": "Har du ikke en konto? <a>Tilmeld dig</a>",

Likely invalid or redundant comment.

@vercel vercel bot temporarily deployed to Preview – landing January 23, 2025 21:03 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
apps/web/public/locales/pt-BR/app.json (1)

Minor inconsistency in login terminology translation

The translation shows good overall consistency, but there's a minor inconsistency in login-related terms:

  • "login" (noun) is translated as informal "Logar"
  • The verb form alternates between "faça login" and "entre"

Consider standardizing to more formal Portuguese:

  • Change "Logar" to "Entrar" or "Iniciar sessão"
  • Use "faça login" consistently for verb form
🔗 Analysis chain

Line range hint 1-308: Verify translation consistency across the file.

Let's check for consistent usage of key terms across the file.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistent translations of key terms

# Function to search for variations of login/entrar
echo "Checking login/entrar variations:"
rg -i "\".*([Ll]ogin|[Ee]ntr[ea]r).*\"" apps/web/public/locales/pt-BR/app.json

# Function to search for variations of account/conta
echo -e "\nChecking account/conta variations:"
rg -i "\".*[Cc]ont[aa].*\"" apps/web/public/locales/pt-BR/app.json

# Function to search for variations of create/criar
echo -e "\nChecking create/criar variations:"
rg -i "\".*([Cc]riar|[Cc]rie).*\"" apps/web/public/locales/pt-BR/app.json

Length of output: 4360

🧹 Nitpick comments (1)
apps/web/public/locales/pt-BR/app.json (1)

285-287: Authentication flow translations look good but could use minor improvements.

The translations are generally good, but there are a few suggestions for better consistency and clarity:

  1. Line 286: continueWithProvider uses double curly braces {{provider}} while line 285 uses single curly braces {provider}. This inconsistency could cause issues.
  2. Line 291: "Login" should be "Entrar" to match line 293's context of "Bem-vindo(a)".
-  "continueWithProvider": "Continuar com {{provider}}",
+  "continueWithProvider": "Continuar com {provider}",
-  "loginDescription": "Entre na sua conta para continuar",
+  "loginDescription": "Entre na sua conta para continuar",

Also applies to: 290-295, 304-308

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e43c3e4 and abe8bd7.

📒 Files selected for processing (2)
  • apps/landing/public/locales/pt-BR/home.json (1 hunks)
  • apps/web/public/locales/pt-BR/app.json (1 hunks)
🔇 Additional comments (3)
apps/landing/public/locales/pt-BR/home.json (2)

42-42: LGTM! Clear and concise meta description.

The translation effectively communicates the meeting poll feature's purpose while maintaining consistency with other meta descriptions.


43-43: LGTM! Well-structured translation for the quick create feature.

The translation "Apresentando o Crie Rápido" is grammatically correct and maintains consistency with the product's naming convention across other language files.

apps/web/public/locales/pt-BR/app.json (1)

296-303: Quick actions translations are well-structured and clear.

The translations effectively communicate the benefits of creating an account while maintaining a friendly tone. The hierarchy of information is logical, starting with the quick action description and following up with the benefits.

@vercel vercel bot temporarily deployed to Preview – landing January 24, 2025 17:36 Inactive
@vercel vercel bot temporarily deployed to Preview – landing January 24, 2025 21:20 Inactive
@vercel vercel bot temporarily deployed to Preview – landing January 24, 2025 22:50 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/web/public/locales/de/app.json (1)

285-286: Consider consolidating similar provider continuation strings.

There are two similar keys for continuing with a provider:

"continueWith": "Weiter mit {provider}",
"continueWithProvider": "Weiter mit {{provider}}"

They use different placeholder styles ({provider} vs {{provider}}). Consider consolidating these to maintain consistency and reduce potential confusion.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9710dd6 and 65759bb.

📒 Files selected for processing (1)
  • apps/web/public/locales/de/app.json (4 hunks)
🔇 Additional comments (3)
apps/web/public/locales/de/app.json (3)

70-71: LGTM! Improved consistency and grammar.

The changes to time format labels and descriptions are more consistent with modern UI practices and provide better German grammar.

Also applies to: 163-163


251-251: LGTM! Well-structured localization string.

The time zone change detector message is properly formatted with HTML tags and includes the necessary placeholder for dynamic content.


296-301: LGTM! Well-structured quick actions section.

The quick actions section effectively communicates the benefits of account creation with clear, concise German translations.

@lukevella lukevella merged commit dc608d6 into main Jan 24, 2025
5 checks passed
@lukevella lukevella deleted the l10n_main branch January 24, 2025 22:54
@coderabbitai coderabbitai bot mentioned this pull request Jan 31, 2025
@coderabbitai coderabbitai bot mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant