[pages] Add Recovery Codes and WebAuthn #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. 🙂 There are some issues that need to be resolved before this PR is merged.
I'll try to find time for this. |
|
Thank you for your input, i'm no frontend dev, but i may try the JS stuff. For now, i just created a secondarySmall button component. |
|
merge? |
Closed
|
What is the current state? Can we help somehow? 👀 |
|
Most of the client code is rewritten in TypeScript following the example of the Recovery Codes pages. I would welcome any help in testing this next week. |
|
Sure. Just comment on this when it's ready 🙌🏼 |
lukin
changed the title
|
Sorry that I had not found time so far. I am writing my bachelor thesis currently. Tested it after i saw your notification and lgtm. |
lukin
added a commit
that referenced
this pull request
Oct 24, 2023
Co-authored-by: Anthony Lukin <anthony@lukin.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for webauthn and recovery codes, based on keycloak base template. Haven't touched the frontend javascript code much, just for
jQuery(...)instead of$(...), could be moved to the main script, but may need some refactoring due to alot of freemarker "injected" variabled into the code.webauthn login
Adding recovery codes:
Authenticator selector